[GitHub] [flink] SwimSweet commented on a diff in pull request #20671: [FLINK-28915] Flink Native k8s mode jar localtion support s3 schema.

[GitBox]

SwimSweet commented on code in PR #20671:
URL: https://github.com/apache/flink/pull/20671#discussion_r953898308


##########
docs/content.zh/docs/deployment/resource-providers/native_kubernetes.md:
##########
@@ -97,14 +97,34 @@ COPY /path/of/my-flink-job.jar 
$FLINK_HOME/usrlib/my-flink-job.jar
 After creating and publishing the Docker image under `custom-image-name`, you 
can start an Application cluster with the following command:
 
 ```bash
+# Local Schema
 $ ./bin/flink run-application \
     --target kubernetes-application \
     -Dkubernetes.cluster-id=my-first-application-cluster \
     -Dkubernetes.container.image=custom-image-name \
     local:///opt/flink/usrlib/my-flink-job.jar
+
+# FileSystem
+$ ./bin/flink run-application \
+    --target kubernetes-application \
+    -Dkubernetes.cluster-id=my-first-application-cluster \
+    -Dkubernetes.container.image=custom-image-name \
+    s3://my-bucket/my-flink-job.jar
+
+# Http/Https Schema
+$ ./bin/flink run-application \
+    --target kubernetes-application \
+    -Dkubernetes.cluster-id=my-first-application-cluster \
+    -Dkubernetes.container.image=custom-image-name \
+    http://ip:port/my-flink-job.jar
 ```
+{{< hint info >}}
+Now, The jar package supports reading from the [flink filesystem]({{< ref 
"docs/deployment/filesystems/overview" >}}#docker-hub-flink-images) or 
Http/Https in Application Mode.  
+The jar package will be downloaded from filesystem to
+[kubernetes.user.artifacts.base.dir]({{< ref "docs/deployment/config" 
>}}#kubernetes-user-artifacts-base-dir)/[kubernetes.namespace]({{< ref 
"docs/deployment/config" >}}#kubernetes-namespace)/[kubernetes.cluster-id]({{< 
ref "docs/deployment/config" >}}#kubernetes-cluster-id) path in image.
+{{< /hint >}}
+<span class="label label-info">Note</span> `local` schema is also supported .

Review Comment:
   `file` schema is pointing to the jar in the container. In this case , 
`local` schema is equal to `file` schema. The difference between `file` and 
`local` is that `local` will return the jar path directly. We will fetch the 
jar  from  the path `file`  points to the path that  
`kubernetes-user-artifacts-base-dir`/`kubernetes-namespace`/`kubernetes-cluster-id`.
   For this ,I have tested.
   
![7183ef3db2ab046fba94a64a9f96baa](https://user-images.githubusercontent.com/21351694/186449987-f227e3ed-f4da-4241-ae37-a359a16bc7f8.png)
   
![00e6f8cb62992bf0bbf413feece51de](https://user-images.githubusercontent.com/21351694/186449122-f7a9dddf-d1de-4f49-ae30-1720e174b027.png)
   
![25939ce0cc994d156d93953e34e7b4c](https://user-images.githubusercontent.com/21351694/186449136-42c88a23-a7e8-4875-b179-963b65790453.png)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org