zentol commented on code in PR #20598:
URL: https://github.com/apache/flink/pull/20598#discussion_r947179550
##########
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporterFactory.java:
##########
@@ -26,8 +26,34 @@
/** {@link MetricReporterFactory} for {@link DatadogHttpReporter}. */
public class DatadogHttpReporterFactory implements MetricReporterFactory {
+ private static final String API_KEY = "apikey";
+ private static final String PROXY_HOST = "proxyHost";
+ private static final String PROXY_PORT = "proxyPort";
+ private static final String DATA_CENTER = "dataCenter";
+ private static final String TAGS = "tags";
+ private static final String MAX_METRICS_PER_REQUEST =
"maxMetricsPerRequest";
+ private static final String USE_LOGICAL_IDENTIFIER =
"useLogicalIdentifier";
+
@Override
- public MetricReporter createMetricReporter(Properties properties) {
- return new DatadogHttpReporter();
+ public MetricReporter createMetricReporter(Properties config) {
+ final String apiKey = config.getProperty(API_KEY, null);
+ final String proxyHost = config.getProperty(PROXY_HOST, null);
+ final int proxyPort = Integer.valueOf(config.getProperty(PROXY_PORT,
"8080"));
+ final String rawDataCenter = config.getProperty(DATA_CENTER, "US");
+ final int maxMetricsPerRequestValue =
+ Integer.valueOf(config.getProperty(MAX_METRICS_PER_REQUEST,
"2000"));
+ final DataCenter dataCenter = DataCenter.valueOf(rawDataCenter);
+ final String tags = config.getProperty(TAGS, "");
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
