qingwei91 commented on PR #20140: URL: https://github.com/apache/flink/pull/20140#issuecomment-1209099214
Hi @libenchao, oh I see, I didnt spot that `JdbcRowDataInputFormat` is using PreparedStatement under the hood. Thanks for pointing it out, this will be larger change than I expect, I will give it a go. > 1. What functions should we support, e.g. IN, BETWEEN? I think we can tackle this incrementally? I believe IN is supported out of the box, because Flink compile IN into multiple X=Y condition chained together by OR, I never looked into BETWEEN though > 2. Are these functions supported in all JDBC dialects, and do they use the same operator? If not, how should we abstract it out to make it dialect specific? I think ultimate we need to allow dialect specificness, right now I design it such that the query generator (ie. JdbcFilterPushdownVisitor) is part of JDBCDialect, so each dialect can provide their own instance to deal with it. Do you think this design is okay? Or is there a better way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
