Myasuka commented on code in PR #20421: URL: https://github.com/apache/flink/pull/20421#discussion_r940412527
########## docs/content/docs/dev/datastream/fault-tolerance/state.md: ########## @@ -474,9 +474,10 @@ ttl_config = StateTtlConfig \ For more fine-grained control over some special cleanup in background, you can configure it separately as described below. Currently, heap state backend relies on incremental cleanup and RocksDB backend uses compaction filter for background cleanup. -##### Cleanup in full snapshot +##### Cleanup in full scan snapshot -Additionally, you can activate the cleanup at the moment of taking the full state snapshot which +Additionally, you can activate the cleanup at the moment of taking the full scan state snapshot (including the canonical savepoint, +or the full/incremental checkpoint of hashmap state-backend, or the full checkpoint of RocksDB state-backend), which Review Comment: I think telling users with a direct explanation of what this API can take effect could be more accurate. And I believe these descriptions would change if we apply new implementations for different state-backend, e.g FLINK-28699 or FLIP-151. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
