gaoyunhaii commented on code in PR #20472: URL: https://github.com/apache/flink/pull/20472#discussion_r939606554
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecDynamicFilteringDataCollector.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.nodes.exec.batch; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.api.dag.Transformation; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.MemorySize; +import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.streaming.api.operators.StreamOperatorFactory; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.planner.delegation.PlannerBase; +import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNode; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeConfig; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeContext; +import org.apache.flink.table.planner.plan.nodes.exec.InputProperty; +import org.apache.flink.table.planner.plan.nodes.exec.utils.ExecNodeUtil; +import org.apache.flink.table.runtime.operators.dynamicfiltering.DynamicFilteringDataCollectorOperatorFactory; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; +import org.apache.flink.table.types.logical.RowType; + +import java.util.Collections; +import java.util.List; + +import static org.apache.flink.configuration.ConfigOptions.key; +import static org.apache.flink.util.Preconditions.checkArgument; + +/** + * Batch {@link ExecNode} that collects inputs and builds {@link + * org.apache.flink.table.connector.source.DynamicFilteringData}, and then sends the {@link + * org.apache.flink.table.connector.source.DynamicFilteringEvent} to the source coordinator. + */ +public class BatchExecDynamicFilteringDataCollector extends ExecNodeBase<Object> + implements BatchExecNode<Object> { + + @Experimental + public static final ConfigOption<MemorySize> TABLE_EXEC_DYNAMIC_FILTERING_THRESHOLD = + key("table.exec.dynamic-filtering.threshold") + .memoryType() + .defaultValue(MemorySize.parse("8 mb")) + .withDescription( + "If the collector collects more data than the threshold(default is 8M), " + + "an empty DynamicFilterEvent with a flag only will be send to Coordinator, " + + "which could avoid exceeding the akka limit(see AkkaOptions#FRAMESIZE). " + + "Otherwise a DynamicFilterEvent with all duplicated records will be send to Coordinator."); Review Comment: nit: duplicated -> deduplicated be send -> be sent ########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecDynamicFilteringDataCollector.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.nodes.exec.batch; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.api.dag.Transformation; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.MemorySize; +import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.streaming.api.operators.StreamOperatorFactory; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.planner.delegation.PlannerBase; +import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNode; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeConfig; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeContext; +import org.apache.flink.table.planner.plan.nodes.exec.InputProperty; +import org.apache.flink.table.planner.plan.nodes.exec.utils.ExecNodeUtil; +import org.apache.flink.table.runtime.operators.dynamicfiltering.DynamicFilteringDataCollectorOperatorFactory; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; +import org.apache.flink.table.types.logical.RowType; + +import java.util.Collections; +import java.util.List; + +import static org.apache.flink.configuration.ConfigOptions.key; +import static org.apache.flink.util.Preconditions.checkArgument; + +/** + * Batch {@link ExecNode} that collects inputs and builds {@link + * org.apache.flink.table.connector.source.DynamicFilteringData}, and then sends the {@link + * org.apache.flink.table.connector.source.DynamicFilteringEvent} to the source coordinator. + */ +public class BatchExecDynamicFilteringDataCollector extends ExecNodeBase<Object> + implements BatchExecNode<Object> { + + @Experimental + public static final ConfigOption<MemorySize> TABLE_EXEC_DYNAMIC_FILTERING_THRESHOLD = + key("table.exec.dynamic-filtering.threshold") + .memoryType() + .defaultValue(MemorySize.parse("8 mb")) + .withDescription( + "If the collector collects more data than the threshold(default is 8M), " + + "an empty DynamicFilterEvent with a flag only will be send to Coordinator, " + + "which could avoid exceeding the akka limit(see AkkaOptions#FRAMESIZE). " Review Comment: nit: `"see" + AkkaOptions.FRAMESIZE.key() + ")." ` avoid exceeding the akka limit -> avoid exceeding the akka limit and out-of-memory ? ########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecDynamicFilteringDataCollector.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.nodes.exec.batch; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.api.dag.Transformation; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.MemorySize; +import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.streaming.api.operators.StreamOperatorFactory; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.planner.delegation.PlannerBase; +import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNode; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeConfig; +import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeContext; +import org.apache.flink.table.planner.plan.nodes.exec.InputProperty; +import org.apache.flink.table.planner.plan.nodes.exec.utils.ExecNodeUtil; +import org.apache.flink.table.runtime.operators.dynamicfiltering.DynamicFilteringDataCollectorOperatorFactory; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; +import org.apache.flink.table.types.logical.RowType; + +import java.util.Collections; +import java.util.List; + +import static org.apache.flink.configuration.ConfigOptions.key; +import static org.apache.flink.util.Preconditions.checkArgument; + +/** + * Batch {@link ExecNode} that collects inputs and builds {@link + * org.apache.flink.table.connector.source.DynamicFilteringData}, and then sends the {@link + * org.apache.flink.table.connector.source.DynamicFilteringEvent} to the source coordinator. + */ +public class BatchExecDynamicFilteringDataCollector extends ExecNodeBase<Object> + implements BatchExecNode<Object> { + + @Experimental + public static final ConfigOption<MemorySize> TABLE_EXEC_DYNAMIC_FILTERING_THRESHOLD = + key("table.exec.dynamic-filtering.threshold") + .memoryType() + .defaultValue(MemorySize.parse("8 mb")) + .withDescription( + "If the collector collects more data than the threshold(default is 8M), " + + "an empty DynamicFilterEvent with a flag only will be send to Coordinator, " Review Comment: nit: be sent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
