lsyldliu commented on code in PR #20442:
URL: https://github.com/apache/flink/pull/20442#discussion_r939516203
##########
flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java:
##########
@@ -85,45 +91,43 @@ public class ParquetColumnarRowInputFormatTest {
private static final org.apache.flink.configuration.Configuration
EMPTY_CONF =
new org.apache.flink.configuration.Configuration();
- private static final MessageType PARQUET_SCHEMA =
- new MessageType(
- "TOP",
- primitive(PrimitiveTypeName.BINARY,
Repetition.OPTIONAL).named("f0"),
- primitive(PrimitiveTypeName.BOOLEAN,
Repetition.OPTIONAL).named("f1"),
- primitive(PrimitiveTypeName.INT32,
Repetition.OPTIONAL).named("f2"),
- primitive(PrimitiveTypeName.INT32,
Repetition.OPTIONAL).named("f3"),
- primitive(PrimitiveTypeName.INT32,
Repetition.OPTIONAL).named("f4"),
- primitive(PrimitiveTypeName.INT64,
Repetition.OPTIONAL).named("f5"),
- primitive(PrimitiveTypeName.FLOAT,
Repetition.OPTIONAL).named("f6"),
- primitive(PrimitiveTypeName.DOUBLE,
Repetition.OPTIONAL).named("f7"),
- primitive(PrimitiveTypeName.INT96,
Repetition.OPTIONAL).named("f8"),
- primitive(PrimitiveTypeName.INT32, Repetition.OPTIONAL)
- .precision(5)
- .as(OriginalType.DECIMAL)
- .named("f9"),
- primitive(PrimitiveTypeName.INT64, Repetition.OPTIONAL)
- .precision(15)
- .as(OriginalType.DECIMAL)
- .named("f10"),
- primitive(PrimitiveTypeName.BINARY, Repetition.OPTIONAL)
- .precision(20)
- .as(OriginalType.DECIMAL)
- .named("f11"),
- primitive(PrimitiveTypeName.FIXED_LEN_BYTE_ARRAY,
Repetition.OPTIONAL)
- .length(16)
- .precision(5)
- .as(OriginalType.DECIMAL)
- .named("f12"),
- primitive(PrimitiveTypeName.FIXED_LEN_BYTE_ARRAY,
Repetition.OPTIONAL)
- .length(16)
- .precision(15)
- .as(OriginalType.DECIMAL)
- .named("f13"),
- primitive(PrimitiveTypeName.FIXED_LEN_BYTE_ARRAY,
Repetition.OPTIONAL)
- .length(16)
- .precision(20)
- .as(OriginalType.DECIMAL)
- .named("f14"));
+ private static final RowType ROW_TYPE =
+ RowType.of(
+ new VarCharType(VarCharType.MAX_LENGTH),
+ new BooleanType(),
+ new TinyIntType(),
+ new SmallIntType(),
+ new IntType(),
+ new BigIntType(),
+ new FloatType(),
+ new DoubleType(),
+ new TimestampType(9),
+ new DecimalType(5, 0),
+ new DecimalType(15, 0),
+ new DecimalType(20, 0),
+ new DecimalType(5, 0),
+ new DecimalType(15, 0),
+ new DecimalType(20, 0),
+ new ArrayType(new VarCharType(VarCharType.MAX_LENGTH)),
+ new ArrayType(new BooleanType()),
+ new ArrayType(new TinyIntType()),
+ new ArrayType(new SmallIntType()),
+ new ArrayType(new IntType()),
+ new ArrayType(new BigIntType()),
+ new ArrayType(new FloatType()),
+ new ArrayType(new DoubleType()),
Review Comment:
Parquet writer doesn't support writer `new ArrayType(new ArrayType(new
DoubleType()))` type now, so this type of test is not good to add, please refer
to `ArrayWriter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
