pltbkd commented on code in PR #20374:
URL: https://github.com/apache/flink/pull/20374#discussion_r937388343
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/DynamicFilteringData.java:
##########
@@ -26,30 +26,49 @@
import org.apache.flink.core.memory.DataInputViewStreamWrapper;
import org.apache.flink.table.api.TableException;
import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.types.logical.LogicalTypeRoot;
import org.apache.flink.table.types.logical.RowType;
import java.io.ByteArrayInputStream;
import java.io.Serializable;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
+import java.util.Collections;
import java.util.HashMap;
+import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Objects;
+import java.util.Set;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import static org.apache.flink.util.Preconditions.checkNotNull;
/** Data for dynamic filtering. */
public class DynamicFilteringData implements Serializable {
+
+ public static final Set<LogicalTypeRoot> SUPPORTED_TYPES;
+
+ static {
+ Set<LogicalTypeRoot> supported = new HashSet<>();
+ supported.add(LogicalTypeRoot.INTEGER);
+ supported.add(LogicalTypeRoot.BIGINT);
+ supported.add(LogicalTypeRoot.SMALLINT);
+ supported.add(LogicalTypeRoot.TINYINT);
+ supported.add(LogicalTypeRoot.VARCHAR);
+ supported.add(LogicalTypeRoot.CHAR);
+ SUPPORTED_TYPES = Collections.unmodifiableSet(supported);
Review Comment:
My apology. I mistook the way hive source to acquire the data. It seems
that we can support all types that hive table spec can describe (in string) and
can be converted to the runtime type, but need to enumerate these types in Hive
source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
