xintongsong commented on code in PR #20429:
URL: https://github.com/apache/flink/pull/20429#discussion_r936559820
##########
flink-core/src/main/java/org/apache/flink/api/common/BatchShuffleMode.java:
##########
@@ -69,11 +69,27 @@ public enum BatchShuffleMode implements DescribedEnum {
* <p>Downstream can start running anytime, as long as the upstream has
started.
*
* <p>This adapts the resource usage to whatever is available.
+ *
+ * <p>This type will spill all data to disk to support re-consume.
+ */
+ // TODO remove the annotation and rename this enum constant when hybrid
shuffle effort is
+ // finished.
+ @Documentation.ExcludeFromDocumentation
+ WIP_ALL_EXCHANGES_HYBRID_FULL(text("DO NOT USE - This feature is in
progress.")),
+
+ /**
+ * *DO NOT USE* - This feature is in progress.
+ *
+ * <p>Downstream can start running anytime, as long as the upstream has
started.
+ *
+ * <p>This adapts the resource usage to whatever is available.
+ *
+ * <p>This type will selective spilling data to reduce disk writes as much
as possible.
*/
// TODO remove the annotation and rename this enum constant when hybrid
shuffle effort is
// finished.
@Documentation.ExcludeFromDocumentation
- WIP_ALL_EXCHANGES_HYBRID(text("DO NOT USE - This feature is in
progress."));
+ WIP_ALL_EXCHANGES_HYBRID_SELECTIVE(text("DO NOT USE - This feature is in
progress."));
Review Comment:
Let's remove the WIP related things now. We can add another commit at the
last of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
