godfreyhe opened a new pull request, #20432: URL: https://github.com/apache/flink/pull/20432
## What is the purpose of the change *for sql: `SELECT * FROM MyTable1 join MyTable2 ON a1 = a2 AND a1 = 2` `a1 = 2` can be pushed into both left side and right side. but currently only left side will be pushed by FilterIntoJoinRule. This pr aims to improve FilterIntoJoinRule: For the above filter of inner/left/right join or the join condition of inner join, the predicate which field references are all from one side join condition can be pushed into another join side* ## Brief change log - *Copy FilterIntoJoinRule from Calcite and do the improvement* ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing This change added tests and can be verified as follows: - *Added FlinkFilterJoinRuleTest tests to verify the logical plan change with FlinkFilterIntoJoinRule* - *Extended JoinTestBase and JoinTest to verify the exec plan for the change* - *Extended JoinITCase to verify the execution result for the change* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org