[
https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15480951#comment-15480951
]
ASF GitHub Bot commented on FLINK-4609:
---------------------------------------
Github user apivovarov commented on a diff in the pull request:
https://github.com/apache/flink/pull/2490#discussion_r78287335
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java
---
@@ -129,14 +129,11 @@ private String getDefaultName() {
public DefaultCross(DataSet<I1> input1, DataSet<I2> input2,
CrossHint hint, String defaultName) {
- super(input1, input2, new DefaultCrossFunction<I1,
I2>(),
+ super(Preconditions.checkNotNull(input1, "input1 is
null"),
--- End diff --
DefaultCross calls `input1.getType()` and `input2.getType()` before calling
super() on line 134. So, if we add null check to super class (e.g.
TwoInputOperator) it will not work for DefaultCross
> Remove redundant check for null in CrossOperator
> ------------------------------------------------
>
> Key: FLINK-4609
> URL: https://issues.apache.org/jira/browse/FLINK-4609
> Project: Flink
> Issue Type: Bug
> Components: Java API
> Affects Versions: 1.1.2
> Reporter: Alexander Pivovarov
> Priority: Trivial
>
> CrossOperator checks input1 and input2 for null after they were dereferenced
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
