Vancior commented on code in PR #20383:
URL: https://github.com/apache/flink/pull/20383#discussion_r934093658


##########
flink-python/pyflink/datastream/connectors/file_system.py:
##########
@@ -535,6 +568,51 @@ def for_row_format(base_path: str, encoder: Encoder) -> 
'FileSink.RowFormatBuild
         return FileSink.RowFormatBuilder(
             JFileSink.forRowFormat(JPath(base_path), encoder._j_encoder))
 
+    class BulkFormatBuilder(object):
+        """
+        Builder for the vanilla FileSink using a bulk format.
+        """
+
+        def __init__(self, j_bulk_format_builder):

Review Comment:
   Maybe we can separate it to another PR? I'm just aligning to the builder in 
StreamingFileSink here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to