[GitHub] [flink] mas-chen commented on a diff in pull request #20234: [FLINK-28475] [Connector/kafka] Stopping offset can be 0

Tue, 19 Jul 2022 17:50:25 -0700 


mas-chen commented on code in PR #20234:
URL: https://github.com/apache/flink/pull/20234#discussion_r925038355


##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReaderTest.java:
##########
@@ -84,6 +85,7 @@ public static void setup() throws Throwable {
         KafkaSourceTestEnv.setup();
         KafkaSourceTestEnv.setupTopic(TOPIC1, true, true, 
KafkaSourceTestEnv::getRecordsForTopic);
         KafkaSourceTestEnv.setupTopic(TOPIC2, true, true, 
KafkaSourceTestEnv::getRecordsForTopic);
+        KafkaSourceTestEnv.setupTopic(TOPIC3, false, false, t -> new 
ArrayList<>());

Review Comment:
   nit
   ```suggestion
           KafkaSourceTestEnv.createTestTopic(TOPIC3);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to