JingGe commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r924934341
########## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitor.java: ########## @@ -53,7 +52,6 @@ * Visitor to walk a Expression AST. Produces a String that can be used to pushdown the filter, * return Optional.empty() if we cannot pushdown the filter. */ -@Public Review Comment: Hi @qingwei91 Could you please explain why a public API is required? Does @Internal work too? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
