MartijnVisser commented on code in PR #20140: URL: https://github.com/apache/flink/pull/20140#discussion_r924911685
########## flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcFilterPushdownVisitor.java: ########## @@ -53,7 +52,6 @@ * Visitor to walk a Expression AST. Produces a String that can be used to pushdown the filter, * return Optional.empty() if we cannot pushdown the filter. */ -@Public Review Comment: > Do you mean we cannot expose new API? You can definitely add a new API to the `master` branch, but the reason why it's problematic here is that you've changed the status of the API in your different commits. That means that when a reviewer is checking individual commits, it shows that you've removed `@Public`. In a later commit, you've again added `@PublicEvolving`. It's better to squash your commits in this case to avoid this type of confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
