morhidi commented on code in PR #316:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/316#discussion_r919652210
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/service/FlinkServiceTest.java:
##########
@@ -293,7 +293,7 @@ public void testClusterInfoRestCompatibility() throws
JsonProcessingException {
String flink14Response =
"{\"refresh-interval\":3000,\"timezone-name\":\"Coordinated
Universal
Time\",\"timezone-offset\":0,\"flink-version\":\"1.14.4\",\"flink-revision\":\"895c609
@
2022-02-25T11:57:14+01:00\",\"features\":{\"web-submit\":false,\"web-cancel\":false}}";
String flink15Response =
- "{\"refresh-interval\":3000,\"timezone-name\":\"Coordinated
Universal
Time\",\"timezone-offset\":0,\"flink-version\":\"1.15.0\",\"flink-revision\":\"3a4c113
@
2022-04-20T19:50:32+02:00\",\"features\":{\"web-submit\":false,\"web-cancel\":false}}";
+ "{\"refresh-interval\":3000,\"timezone-name\":\"Coordinated
Universal
Time\",\"timezone-offset\":0,\"flink-version\":\"1.15.1\",\"flink-revision\":\"3a4c113
@
2022-04-20T19:50:32+02:00\",\"features\":{\"web-submit\":false,\"web-cancel\":false}}";
Review Comment:
We could potentially remove this test, since the e2e tests would cover the
functionality. I guess I'll just remove the flink15Response check since the
schema didn't change between 1.14 and 1.15. It's good to have a test showing
the schema changes tho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
