[
https://issues.apache.org/jira/browse/FLINK-28428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563273#comment-17563273
]
LuNing Wang edited comment on FLINK-28428 at 7/6/22 2:46 PM:
-------------------------------------------------------------
Whether this
[commit|https://github.com/apache/flink-connector-elasticsearch/commit/3c9430593d9d61254b63a66234d8dba9c269060b]
changes an error doc file? Should we change the English doc but change the
Chinese doc? The only one doc is correct, either Chinese or English.
I found the Chinese translations of _+IMPORTANT: Checkpointing is not enabled
by default but ....... +_ was deleted and the example of the fault tolerance
section in the English doc wasn't updated in this former commit.
was (Author: ana4):
Whether this
[commit](https://github.com/apache/flink-connector-elasticsearch/commit/3c9430593d9d61254b63a66234d8dba9c269060b)
changes an error doc file? Should we change the English doc but change the
Chinese doc? The only one doc is correct, either Chinese or English.
I found the Chinese translations of {{IMPORTANT: Checkpointing is not enabled
by default but .......}} was deleted and the example of the fault tolerance
section in the English doc wasn't updated in this former commit.
> Example in the Elasticsearch doc of fault tolerance section is missing
> ----------------------------------------------------------------------
>
> Key: FLINK-28428
> URL: https://issues.apache.org/jira/browse/FLINK-28428
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / ElasticSearch, Documentation
> Affects Versions: 1.15.1
> Reporter: LuNing Wang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.16.0
>
>
> The example in English doc
> {code:java}
> final StreamExecutionEnvironment env =
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.enableCheckpointing(5000); // checkpoint every 5000 msecs{code}
>
> The example in Chinese doc
> {code:java}
> final StreamExecutionEnvironment env =
> StreamExecutionEnvironment.getExecutionEnvironment();
> env.enableCheckpointing(5000); // 每 5000 毫秒执行一次 checkpoint
> Elasticsearch6SinkBuilder sinkBuilder = new
> Elasticsearch6SinkBuilder<String>()
> .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
> .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
> .setEmitter(
> (element, context, indexer) ->
> indexer.add(createIndexRequest(element))); {code}
> IMO, the example in Chinese doc is correct.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
