gyfora commented on PR #283: URL: https://github.com/apache/flink-kubernetes-operator/pull/283#issuecomment-1172019857
@morhidi @Aitozi I tried to address the comments. I only added the isFirstDeployment check utility method. While I partially agreed with some other comments regarding conditions, generation handling for rollbacks etc. but I found no easy way to incoporate those suggestions in a way that would make the code structure or the functionality better. Even before the comments I have thought about those cases but I think the current logic would work reliably. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
