[GitHub] [flink] reswqa commented on a diff in pull request #19960: [FLINK-27907][runtime] implement disk read and write logic for hybrid shuffle

[GitBox]

reswqa commented on code in PR #19960:
URL: https://github.com/apache/flink/pull/19960#discussion_r910774514


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferReaderWriterUtil.java:
##########
@@ -200,12 +211,32 @@ static Buffer readFromByteChannel(
         return new NetworkBuffer(memorySegment, bufferRecycler, dataType, 
isCompressed, size);
     }
 
-    static ByteBuffer allocatedHeaderBuffer() {
+    public static ByteBuffer allocatedHeaderBuffer() {
         ByteBuffer bb = ByteBuffer.allocateDirect(HEADER_LENGTH);
         configureByteBuffer(bb);
         return bb;
     }
 
+    public static void positionToNextBuffer(FileChannel channel, ByteBuffer 
headerBuffer)

Review Comment:
   added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org