dianfu commented on code in PR #20029:
URL: https://github.com/apache/flink/pull/20029#discussion_r906937708


##########
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java:
##########
@@ -579,6 +662,21 @@ private void checkIfPreviousPatternGreedy() {
         }
     }
 
+    private void checkWindowTimeBetweenEvents(Time windowTime, WithinType 
withinType) {

Review Comment:
   What about moving this validation to NFAFactoryCompilter.compileFactory? The 
window time of `FIRST_AND_LAST` may be defined in other Pattern object which is 
only available during compiling the Pattern. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to