[GitHub] [flink] swuferhong commented on a diff in pull request #20007: [FLINK-27989][table-planner] Csv format supports reporting statistics

[GitBox]

swuferhong commented on code in PR #20007:
URL: https://github.com/apache/flink/pull/20007#discussion_r905696463


##########
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvFileFormatFactory.java:
##########
@@ -136,6 +147,45 @@ public BulkFormat<RowData, FileSourceSplit> 
createRuntimeDecoder(
         public ChangelogMode getChangelogMode() {
             return ChangelogMode.insertOnly();
         }
+
+        @Override
+        public TableStats reportStatistics(List<Path> files, DataType 
producedDataType) {
+            final int totalSampleLineCnt = 100;

Review Comment:
   > 
   
   Thanks @fsk119 . Not likes Orc and Parquet format,  Csv table stats are very 
rough estimate values, and don't include getting column statistics. Therefore, 
I think this value has little impact on the accuracy of Csv stats results. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org