zhipeng93 commented on code in PR #111:
URL: https://github.com/apache/flink-ml/pull/111#discussion_r901202605
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/BenchmarkUtils.java:
##########
@@ -99,6 +99,7 @@ private static BenchmarkResult runBenchmark(
DataGenerator<?> modelDataGenerator)
throws Exception {
StreamExecutionEnvironment env =
TableUtils.getExecutionEnvironment(tEnv);
+ env.getConfig().enableObjectReuse();
Review Comment:
Thanks for the suggestion. I agree that users won't use BenchmarkUtils in
the production code so it won't lead to wrong results.
I also agree that we should make sure that FlinkML algs can run with
object-reuse enabled. We could add the check in another PR.
I have moved the setting to `Benchmark::executeBenchmarks()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
