[
https://issues.apache.org/jira/browse/FLINK-28109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LuNing Wang updated FLINK-28109:
--------------------------------
Description:
The `.id(key)` in the RowElasticsearchEmitter make users get confused.
The following is the source code. key always null, we can never call the `id`
method.
{code:java}
if (key != null) {
final UpdateRequest updateRequest =
new UpdateRequest(indexGenerator.generate(row), documentType, key)
.doc(document, contentType)
.upsert(document, contentType);
indexer.add(updateRequest);
} else {
final IndexRequest indexRequest =
new IndexRequest(indexGenerator.generate(row), documentType)
.id(key)
.source(document, contentType);
indexer.add(indexRequest);
}{code}
was:
The `.id(key)` in the RowElasticsearchEmitter make users get confused/
The following is the source code. key always null, we can never call the `id`
method.
{code:java}
final IndexRequest indexRequest =
new IndexRequest(indexGenerator.generate(row), documentType)
.id(key)
.source(document, contentType);
indexer.add(indexRequest); {code}
> Delete useful code in the row emitter.
> --------------------------------------
>
> Key: FLINK-28109
> URL: https://issues.apache.org/jira/browse/FLINK-28109
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / ElasticSearch
> Affects Versions: 1.15.0
> Reporter: LuNing Wang
> Priority: Major
> Fix For: 1.16.0
>
>
>
> The `.id(key)` in the RowElasticsearchEmitter make users get confused.
> The following is the source code. key always null, we can never call the `id`
> method.
> {code:java}
> if (key != null) {
> final UpdateRequest updateRequest =
> new UpdateRequest(indexGenerator.generate(row), documentType, key)
> .doc(document, contentType)
> .upsert(document, contentType);
> indexer.add(updateRequest);
> } else {
> final IndexRequest indexRequest =
> new IndexRequest(indexGenerator.generate(row), documentType)
> .id(key)
> .source(document, contentType);
> indexer.add(indexRequest);
> }{code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
