luoyuxia commented on code in PR #19561: URL: https://github.com/apache/flink/pull/19561#discussion_r899806204
########## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/planner/delegation/hive/HiveASTParserTest.java: ########## @@ -139,6 +139,13 @@ public void testFunction() throws Exception { assertDDLType(HiveASTParser.TOK_SHOWFUNCTIONS, "show functions"); } + @Test + public void testMacro() throws Exception { Review Comment: we may not need for macro with a qualified name will fail in parse phase. The antrl segment is like follows: ` KW_CREATE KW_TEMPORARY KW_MACRO Identifier LPAREN columnNameTypeList? RPAREN expression -> ^(TOK_CREATEMACRO Identifier columnNameTypeList? expression)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org