LadyForest commented on code in PR #138: URL: https://github.com/apache/flink-table-store/pull/138#discussion_r882366370
########## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreReadImpl.java: ########## @@ -55,14 +56,14 @@ public FileStoreReadImpl( WriteMode writeMode, RowType keyType, RowType valueType, - Comparator<RowData> keyComparator, + Supplier<Comparator<RowData>> keyComparatorSupplier, Review Comment: Since `pickManifest` needs `keyComparator`, so I extract a util method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org