[ https://issues.apache.org/jira/browse/FLINK-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446154#comment-15446154 ]
ASF GitHub Bot commented on FLINK-4496: --------------------------------------- Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2434 I had comments about introducing an interface for the asynchronous excepts, other than that and @rmetzger's comment this looks good. I like the addition of the `TimeProviderTest`. 👍 > Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable. > ---------------------------------------------------------------------------- > > Key: FLINK-4496 > URL: https://issues.apache.org/jira/browse/FLINK-4496 > Project: Flink > Issue Type: Sub-task > Reporter: Kostas Kloudas > Assignee: Kostas Kloudas > -- This message was sent by Atlassian JIRA (v6.3.4#6332)