[
https://issues.apache.org/jira/browse/FLINK-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445550#comment-15445550
]
ASF GitHub Bot commented on FLINK-4517:
---------------------------------------
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2428
@StephanEwen Thank for your reply.
These code change such as case class usage are not forced to observe. But
there are scala best practice. We can update every kind of problem, at same
time update scala check-style rule if exist. :)
> scala code refactoring
> ----------------------
>
> Key: FLINK-4517
> URL: https://issues.apache.org/jira/browse/FLINK-4517
> Project: Flink
> Issue Type: Improvement
> Reporter: shijinkui
> Priority: Minor
>
> such as:
> 1. case class does't need `new`
> 2. case block does't need `{ ... }`
> 3. match-case instead of isInstanceOf
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
