wangyang0918 commented on code in PR #216:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/216#discussion_r874334467
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java:
##########
@@ -431,11 +431,12 @@ public void cancelJob(FlinkDeployment deployment,
UpgradeMode upgradeMode) throw
}
deploymentStatus.getJobStatus().setState(JobStatus.FINISHED.name());
savepointOpt.ifPresent(
- location ->
- deploymentStatus
- .getJobStatus()
- .getSavepointInfo()
- .setLastSavepoint(Savepoint.of(location)));
+ location -> {
+ Savepoint sp = Savepoint.of(location);
+
deploymentStatus.getJobStatus().getSavepointInfo().setLastSavepoint(sp);
+ // this is required for Flink < 1.15
+
deploymentStatus.getJobStatus().getSavepointInfo().addSavepointToHistory(sp);
Review Comment:
We also need to do this for `FlinkSessionJobReconciler`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
