gyfora commented on code in PR #216:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/216#discussion_r873738822
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SavepointObserver.java:
##########
@@ -131,9 +136,56 @@ private Optional<String> observeTriggeredSavepointProgress(
LOG.info("Savepoint status updated with latest completed savepoint
info");
currentSavepointInfo.updateLastSavepoint(savepointFetchResult.getSavepoint());
+ updateSavepointHistory(
+ currentSavepointInfo, savepointFetchResult.getSavepoint(),
deployedConfig);
Review Comment:
I think we should also update the savepoint history when we shut down using
savepoint. (Or in case of failure of the shutdown operation as part of the
`observeLatestSavepoint`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
