[ https://issues.apache.org/jira/browse/FLINK-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439239#comment-15439239 ]
ASF GitHub Bot commented on FLINK-4459: --------------------------------------- GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/2424 [FLINK-4459][Scheduler] Introduce SlotProvider for Scheduler Introduce SlotProvider, prepare for the further slot allocation refactoring You can merge this pull request into a Git repository by running: $ git pull https://github.com/KurtYoung/flink flink-4459 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2424.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2424 ---- commit b88f024e6c6b134d00588af6aab8c03a189d2d3a Author: Kurt Young <ykt...@gmail.com> Date: 2016-08-26T09:51:40Z [FLINK-4459][Scheduler] Introduce SlotProvider for Scheduler ---- > Introduce SlotProvider for Scheduler > ------------------------------------ > > Key: FLINK-4459 > URL: https://issues.apache.org/jira/browse/FLINK-4459 > Project: Flink > Issue Type: Improvement > Components: Scheduler > Reporter: Till Rohrmann > Assignee: Kurt Young > > Currently the {{Scheduler}} maintains a queue of available instances which it > scans if it needs a new slot. If it finds a suitable instance (having free > slots available) it will allocate a slot from it. > This slot allocation logic can be factored out and be made available via a > {{SlotProvider}} interface. The {{SlotProvider}} has methods to allocate a > slot given a set of location preferences. Slots should be returned as > {{Futures}}, because in the future the slot allocation might happen > asynchronously (Flip-6). > In the first version, the {{SlotProvider}} implementation will simply > encapsulate the existing slot allocation logic extracted from the > {{Scheduler}}. When a slot is requested it will return a completed or failed > future since the allocation happens synchronously. > The refactoring will have the advantage to simplify the {{Scheduler}} class > and to pave the way for upcoming refactorings (Flip-6). -- This message was sent by Atlassian JIRA (v6.3.4#6332)