empcl commented on PR #19573: URL: https://github.com/apache/flink/pull/19573#issuecomment-1112448067
@luoyuxia Regarding adding test cases, I'm sorry, I can't verify this change on HivePartitionFetcherTest. Because, the test case above HivePartitionFetcherTest cannot actually obtain the specific partition information (that is why `assertEquals(0, fetcherContext.getComparablePartitionValueList().size());`). In addition, because the aspect of my modification is to operate on a known partition during the running of the program. In terms of current test mocks, it doesn't meet my needs. So, I'm sorry for not being able to provide relevant test cases to meet my needs. However, I have verified the correctness of the code on a distributed cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
