[
https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436852#comment-15436852
]
ASF GitHub Bot commented on FLINK-4245:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2418
[FLINK-4245] JMXReporter exposes all defined variables
This PR is a follow-up to cbbd80033204a922ccf148c5ac3f1be6de0d810d. It
exposes the introduced map of variables via JMX by adding a new method
`getVariables()` to the JMX metric interfaces.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink metrics_tags_jmx
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2418.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2418
----
commit be55aa1bdaf8a574ba2a34786507a691af748dde
Author: zentol <[email protected]>
Date: 2016-07-27T10:29:10Z
[FLINK-4245] JMXReporter exposes all defined variables
----
> Metric naming improvements
> --------------------------
>
> Key: FLINK-4245
> URL: https://issues.apache.org/jira/browse/FLINK-4245
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Reporter: Stephan Ewen
>
> A metric currently has two parts to it:
> - The name of that particular metric
> - The "scope" (or namespace), defined by the group that contains the metric.
> A metric group actually always implicitly has a map of naming "tags", like:
> - taskmanager_host : <some-hostname>
> - taskmanager_id : <id>
> - task_name : "map() -> filter()"
> We derive the scope from that map, following the defined scope formats.
> For JMX (and some users that use JMX), it would be natural to expose that map
> of tags. Some users reconstruct that map by parsing the metric scope. JMX, we
> can expose a metric like:
> - domain: "taskmanager.task.operator.io"
> - name: "numRecordsIn"
> - tags: { "hostname" -> "localhost", "operator_name" -> "map() at
> X.java:123", ... }
> For many other reporters, the formatted scope makes a lot of sense, since
> they think only in terms of (scope, metric-name).
> We may even have the formatted scope in JMX as well (in the domain), if we
> want to go that route.
> [~jgrier] and [~Zentol] - what do you think about that?
> [~mdaxini] Does that match your use of the metrics?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
