[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #87: [FLINK-27123] Introduce filter predicate for 'LIKE'

[GitBox]

JingsongLi commented on code in PR #87:
URL: https://github.com/apache/flink-table-store/pull/87#discussion_r847942602


##########
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/predicate/PredicateTest.java:
##########
@@ -325,11 +345,29 @@ public void testUnsupportedExpression() {
                                 field(0, DataTypes.INT()),
                                 literal(3)),
                         call(
-                                BuiltInFunctionDefinitions.LIKE,
+                                BuiltInFunctionDefinitions.SIMILAR,
                                 field(1, DataTypes.INT()),
                                 literal(5)));
         assertThatThrownBy(() -> expression.accept(CONVERTER))
                 .isInstanceOf(PredicateConverter.UnsupportedExpression.class);
+
+        CallExpression endPattern =

Review Comment:
   There can be a `testUnsupportedLike` to test like only.
   The test cases can be:
   - equalsPattern/endPattern/middlePattern
   - equalsPattern/endPattern/middlePattern with escape
   - equalsPattern/endPattern/middlePattern with '_'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org