[
https://issues.apache.org/jira/browse/FLINK-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434446#comment-15434446
]
Ismaël Mejía commented on FLINK-4326:
-------------------------------------
Just to make some progress here, I see three options:
1. I reopen my PR and we let it like it was (it already works and makes the
intended goal but has the weirdness of calling flink-daemon.sh start-foreground
...).
2. I reopen my PR but rename flink-daemon to flink-service to avoid the mix of
daemon+foreground (the negative part of this is that it may break some scripts
for people using flink-daemon directly).
3. We create the additional flink-console script with the issue of copy pasting
a small chunk of code at the beginning and keeping both in the future (well we
can create some sort of common bash code library, but remember bash is not the
nicest language for reuse).
I prefer option 1 because it reuses all the code and it is already done and
tested. and I probably could do option 2 or 3 if most people agree on one of
those, but I will still need help from your part for the new review + some
testing (in particular for case 3).
WDYT or do you have other suggestions ?
> Flink start-up scripts should optionally start services on the foreground
> -------------------------------------------------------------------------
>
> Key: FLINK-4326
> URL: https://issues.apache.org/jira/browse/FLINK-4326
> Project: Flink
> Issue Type: Improvement
> Components: Startup Shell Scripts
> Affects Versions: 1.0.3
> Reporter: Elias Levy
>
> This has previously been mentioned in the mailing list, but has not been
> addressed. Flink start-up scripts start the job and task managers in the
> background. This makes it difficult to integrate Flink with most processes
> supervisory tools and init systems, including Docker. One can get around
> this via hacking the scripts or manually starting the right classes via Java,
> but it is a brittle solution.
> In addition to starting the daemons in the foreground, the start up scripts
> should use exec instead of running the commends, so as to avoid forks. Many
> supervisory tools assume the PID of the process to be monitored is that of
> the process it first executes, and fork chains make it difficult for the
> supervisor to figure out what process to monitor. Specifically,
> jobmanager.sh and taskmanager.sh should exec flink-daemon.sh, and
> flink-daemon.sh should exec java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
