Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r76010171
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/JsonRowSerializationSchemaTest.java
---
@@ -35,19 +35,29 @@ public void testRowSerialization() throws IOException {
row.setField(1, true);
row.setField(2, "str");
+ Row resultRow = serializeAndDeserialize(fieldNames, fieldTypes,
row);
+ assertEqualRows(row, resultRow);
+ }
- JsonRowSerializationSchema serializationSchema = new
JsonRowSerializationSchema(fieldNames);
- JsonRowDeserializationSchema deserializationSchema = new
JsonRowDeserializationSchema(fieldNames, fieldTypes);
+ @Test
+ public void testSerializationOfTwoRows() throws IOException {
--- End diff --
Actually, the test I wanted to propose should serialize two rows (with same
schema) using the same `JsonRowSerializationSchema` and
`JsonRowDeserializationSchema` to make sure that there are no side effects.
This is also what happens in the table source.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
