[
https://issues.apache.org/jira/browse/FLINK-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433174#comment-15433174
]
ASF GitHub Bot commented on FLINK-4451:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2405#discussion_r75905953
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/registration/RetryingRegistration.java
---
@@ -197,7 +197,7 @@ public void onSuccess(Gateway result) {
@Override
public void onFailure(Throwable failure) {
if (!isCanceled()) {
- log.warn("Could not resolve {}
address {}, retrying...", targetName, targetAddress);
+ log.warn("Could not resolve {}
address {}, retrying...", targetName, targetAddress, failure);
--- End diff --
I think you cannot mix argument markers and exception logging.
> Throw exception when remote connection cannot be resolved
> ---------------------------------------------------------
>
> Key: FLINK-4451
> URL: https://issues.apache.org/jira/browse/FLINK-4451
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The {{RpcService}} implementation should throw an exception (returned in the
> future) if {{RpcService.connect(address, type)}} cannot connect to the remote
> {{RpcEndpoint}}.
> At the moment the {{AkkaRpcService}} does not check that the
> {{IdentifyActor}} message contains a valid {{ActorRef}} and throws due to
> that a {{NullPointerException}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
