slinkydeveloper commented on a change in pull request #18109:
URL: https://github.com/apache/flink/pull/18109#discussion_r839657580
##########
File path:
flink-table/flink-table-api-java-bridge/src/test/java/org/apache/flink/table/factories/DataGenTableSourceFactoryTest.java
##########
@@ -178,6 +192,10 @@ public void testSource() throws Exception {
Assert.assertEquals(i + 50, row.getLong(2));
final TimestampData f3 = row.getTimestamp(3, 3);
Assert.assertTrue(f3.getMillisecond() >= begin - 5000 &&
f3.getMillisecond() <= end);
+ final MapData f4 = row.getMap(4);
+ Assert.assertTrue(f4.keyArray().isNullAt(0));
Review comment:
assertj :smile:
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenConnectorOptions.java
##########
@@ -109,5 +110,12 @@
.noDefaultValue()
.withDescription("End value of sequence generator.");
+ /** Placeholder {@link ConfigOption}. Not used for retrieving values. */
+ public static final ConfigOption<Float> FIELD_NULL_RATE =
+ ConfigOptions.key(String.format("%s.#.%s", FIELDS, NULL_RATE))
+ .floatType()
+ .noDefaultValue()
Review comment:
Maybe default value `0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
