[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432544#comment-15432544
]
ASF GitHub Bot commented on FLINK-3874:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2244#discussion_r75835251
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/sinks/TableSink.scala
---
@@ -41,46 +38,13 @@ trait TableSink[T] {
*/
def getOutputType: TypeInformation[T]
- /** Return a deep copy of the [[TableSink]]. */
- protected def copy: TableSink[T]
-
- /**
- * Return the field names of the [[org.apache.flink.api.table.Table]]
to emit. */
- protected final def getFieldNames: Array[String] = {
- fieldNames match {
- case Some(n) => n
- case None => throw new IllegalStateException(
- "TableSink must be configured to retrieve field names.")
- }
- }
-
- /** Return the field types of the [[org.apache.flink.api.table.Table]]
to emit. */
- protected final def getFieldTypes: Array[TypeInformation[_]] = {
- fieldTypes match {
- case Some(t) => t
- case None => throw new IllegalStateException(
- "TableSink must be configured to retrieve field types.")
- }
- }
-
- /**
- * Return a copy of this [[TableSink]] configured with the field names
and types of the
--- End diff --
Please keep the documentation for `configure()`. It is crucial that
`configure()` returns a copy and not the same object.
> Add a Kafka TableSink with JSON serialization
> ---------------------------------------------
>
> Key: FLINK-3874
> URL: https://issues.apache.org/jira/browse/FLINK-3874
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Ivan Mushketyk
> Priority: Minor
>
> Add a TableSink that writes JSON serialized data to Kafka.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
