[
https://issues.apache.org/jira/browse/FLINK-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431184#comment-15431184
]
ASF GitHub Bot commented on FLINK-4278:
---------------------------------------
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2403
[FLINK-4278]: Unclosed FSDataOutputStream in multiple files in the project
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- JIRA: https://issues.apache.org/jira/browse/FLINK-4278
- Added the close statements for the FSStateBackend, StringWriter and
FileSystemStateStorageHelper for the unclosed FileDataOutputStream objects.
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- No documentation needed here.
- [ ] Tests & Build
- `mvn clean verify` has been executed successfully locally or a Travis
build has failed but the failure does not seem related. Can do a re-run and
verify on the PR itself.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/flink FLINK-4278
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2403.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2403
----
commit 844c9893045a4257630ed1ca564f67db0dee0b4a
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-08-15T21:28:36Z
FLINK-4278: Added close method calls to FSDataOutputStream and
FsStateBackend
commit d7d1273d7fee1fa728f97aa1fca360bad96c804d
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-08-16T03:42:25Z
FLINK-4278: Added close method to the FileSystemStateStorageHelper and
StringWriter
----
> Unclosed FSDataOutputStream in multiple files in the project
> ------------------------------------------------------------
>
> Key: FLINK-4278
> URL: https://issues.apache.org/jira/browse/FLINK-4278
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.0.3
> Reporter: Neelesh Srinivas Salian
> Assignee: Neelesh Srinivas Salian
>
> After FLINK-4259, I did a check and found that the following files don't have
> the closing of the FSDataOutputStream.
> The following are the files and the corresponding methods missing the close()
> 1) FSDataOutputStream.java adding a close method in the abstract class
> 2) FSStateBackend flush() and write() - closing the FSDataOutputStream
> 3) StringWriter.java write()
> 4) FileSystemStateStore putState() - closing the FSDataOutputStream
> 5) HadoopDataOutputStream.java not too sure if this needs closing.
> 6) FileSystemStateStorageHelper.java store() need closing for both outStream
> and the ObjectOutputStream
> The options to think would be to either close or use IOUtils.closeQuietly()
> Any thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
