[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430714#comment-15430714
]
ASF GitHub Bot commented on FLINK-4348:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2389#discussion_r75672201
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/taskexecutor/SlotReport.java
---
@@ -18,21 +18,38 @@
package org.apache.flink.runtime.rpc.taskexecutor;
+import org.apache.flink.runtime.clusterframework.types.ResourceID;
+
import java.io.Serializable;
+import java.util.List;
/**
* A report about the current status of all slots of the TaskExecutor,
describing
* which slots are available and allocated, and what jobs (JobManagers)
the allocated slots
* have been allocated to.
*/
-public class SlotReport implements Serializable{
+public class SlotReport implements Serializable {
+
+ private static final long serialVersionUID = -3150175198722481689L;
+
+ /** the status of all slots of the TaskManager */
+ private final List<SlotStatus> slotsStatus;
- private static final long serialVersionUID = 1L;
+ // resourceID identify the taskExecutor
--- End diff --
I know we're not overly consistent with that but field descriptions use
normally the multi-line comment style `/** .... */`.
> Implement communication from ResourceManager to TaskManager
> -----------------------------------------------------------
>
> Key: FLINK-4348
> URL: https://issues.apache.org/jira/browse/FLINK-4348
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Kurt Young
> Assignee: zhangjing
>
> There are mainly 3 logics initiated from RM to TM:
> * Heartbeat, RM use heartbeat to sync with TM's slot status
> * SlotRequest, when RM decides to assign slot to JM, should first try to send
> request to TM for slot. TM can either accept or reject this request.
> * FailureNotify, in some corner cases, TM will be marked as invalid by
> cluster manager master(e.g. yarn master), but TM itself does not realize. RM
> should send failure notify to TM and TM can terminate itself
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
