Github user shixiaogang commented on a diff in the pull request:
https://github.com/apache/flink/pull/2377#discussion_r75479936
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/jobmaster/JobMaster.java
---
@@ -135,12 +256,12 @@ public void registerAtResourceManager(final String
address) {
*
* @param jobMasterRegistration Job master registration info which is
sent to the resource
* manager
- * @param attemptNumber Registration attempt number
+ * @param attemptNumber Registration attempt number
* @param resourceManagerFuture Future of the resource manager gateway
- * @param registrationRun UUID describing the current registration run
- * @param timeout Timeout of the last registration attempt
- * @param maxTimeout Maximum timeout between registration attempts
- * @param deadline Deadline for the registration
+ * @param registrationRun UUID describing the current
registration run
+ * @param timeout Timeout of the last registration attempt
+ * @param maxTimeout Maximum timeout between registration
attempts
+ * @param deadline Deadline for the registration
*/
void handleResourceManagerRegistration(
--- End diff --
The differences made here is due to the automatic code reformatting. I
focused on the implementation of leader election in this PR. Hence, I did not
delete your code about registration here.
Since the code will not be used in the following PR, I will delete it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
