[ 
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428139#comment-15428139
 ] 

ASF GitHub Bot commented on FLINK-4389:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2363#discussion_r75474901
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java
 ---
    @@ -61,9 +58,7 @@ public TaskManagerJobMetricGroup(
                        JobID jobId,
                        @Nullable String jobName) {
     
    -           super(registry, jobId, jobName, scopeFormat.formatScope(parent, 
jobId, jobName));
    -
    -           this.parent = checkNotNull(parent);
    +           super(registry, checkNotNull(parent), jobId, jobName, 
scopeFormat.formatScope(parent, jobId, jobName));
    --- End diff --
    
    Why do you do them at all if you want to save them in the first place?


> Expose metrics to Webfrontend
> -----------------------------
>
>                 Key: FLINK-4389
>                 URL: https://issues.apache.org/jira/browse/FLINK-4389
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Metrics, Webfrontend
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-7%3A+Expose+metrics+to+WebInterface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to