Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2304#discussion_r75459189
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/types/parser/BigDecParser.java ---
    @@ -0,0 +1,126 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +
    +package org.apache.flink.types.parser;
    +
    +import java.math.BigDecimal;
    +import org.apache.flink.annotation.PublicEvolving;
    +
    +/**
    + * Parses a text field into a {@link java.math.BigDecimal}.
    + */
    +@PublicEvolving
    +public class BigDecParser extends FieldParser<BigDecimal> {
    +
    +   private static final BigDecimal BIG_DECIMAL_INSTANCE = BigDecimal.ZERO;
    +
    +   private BigDecimal result;
    +
    +   @Override
    +   public int parseField(byte[] bytes, int startPos, int limit, byte[] 
delimiter, BigDecimal reusable) {
    +           int i = startPos;
    +
    +           final int delimLimit = limit - delimiter.length + 1;
    +
    +           while (i < limit) {
    +                   if (i < delimLimit && delimiterNext(bytes, i, 
delimiter)) {
    +                           if (i == startPos) {
    +                                   
setErrorState(ParseErrorState.EMPTY_STRING);
    +                                   return -1;
    +                           }
    +                           break;
    +                   }
    +                   i++;
    +           }
    +
    +           if (i > startPos &&
    +                           (Character.isWhitespace(bytes[startPos]) || 
Character.isWhitespace(bytes[(i - 1)]))) {
    +                   
setErrorState(ParseErrorState.NUMERIC_VALUE_ILLEGAL_CHARACTER);
    +                   return -1;
    +           }
    +
    +           String str = new String(bytes, startPos, i - startPos);
    +           try {
    +                   this.result = new BigDecimal(str);
    +                   return (i == limit) ? limit : i + delimiter.length;
    +           } catch (NumberFormatException e) {
    +                   
setErrorState(ParseErrorState.NUMERIC_VALUE_FORMAT_ERROR);
    +                   return -1;
    +           }
    +   }
    +
    +   @Override
    +   public BigDecimal createValue() {
    +           return BIG_DECIMAL_INSTANCE;
    +   }
    +
    +   @Override
    +   public BigDecimal getLastResult() {
    +           return this.result;
    +   }
    +
    +   /**
    +    * Static utility to parse a field of type BigDecimal from a byte 
sequence that represents text
    +    * characters
    +    * (such as when read from a file stream).
    +    *
    +    * @param bytes    The bytes containing the text data that should be 
parsed.
    +    * @param startPos The offset to start the parsing.
    +    * @param length   The length of the byte sequence (counting from the 
offset).
    +    * @return The parsed value.
    +    * @throws NumberFormatException Thrown when the value cannot be parsed 
because the text 
    +    * represents not a correct number.
    +    */
    +   public static final BigDecimal parseField(byte[] bytes, int startPos, 
int length) {
    +           return parseField(bytes, startPos, length, (char) 0xffff);
    +   }
    +
    +   /**
    +    * Static utility to parse a field of type BigDecimal from a byte 
sequence that represents text
    +    * characters
    +    * (such as when read from a file stream).
    +    *
    +    * @param bytes     The bytes containing the text data that should be 
parsed.
    +    * @param startPos  The offset to start the parsing.
    +    * @param length    The length of the byte sequence (counting from the 
offset).
    +    * @param delimiter The delimiter that terminates the field.
    +    * @return The parsed value.
    +    * @throws NumberFormatException Thrown when the value cannot be parsed 
because the text 
    +    * represents not a correct number.
    +    */
    +   public static final BigDecimal parseField(byte[] bytes, int startPos, 
int length, char delimiter) {
    +           if (length <= 0) {
    +                   throw new NumberFormatException("Invalid input: Empty 
string");
    +           }
    +           int i = 0;
    +           final byte delByte = (byte) delimiter;
    +
    +           while (i < length && bytes[startPos + i] != delByte) {
    +                   i++;
    +           }
    +
    +           if (i > 0 &&
    +                           (Character.isWhitespace(bytes[startPos]) || 
Character.isWhitespace(bytes[startPos + i - 1]))) {
    +                   throw new NumberFormatException("There is leading or 
trailing whitespace in the numeric field.");
    +           }
    +
    +           String str = new String(bytes, startPos, i);
    --- End diff --
    
    same as above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to