twalthr commented on a change in pull request #19045:
URL: https://github.com/apache/flink/pull/19045#discussion_r828186300
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/SearchOperatorGen.scala
##########
@@ -82,14 +82,14 @@ object SearchOperatorGen {
.map(CastRuleProvider.cast(toCastContext(ctx), sargType, commonType,
_))
.map(generateLiteral(ctx, _, commonType))
if (sarg.containsNull) {
- haystack += generateNullLiteral(commonType, ctx.nullCheck)
+ haystack += generateNullLiteral(commonType)
}
val setTerm = ctx.addReusableHashSet(haystack.toSeq, commonType)
val negation = if (sarg.isComplementedPoints) "!" else ""
val Seq(resultTerm, nullTerm) = newNames("result", "isNull")
- val operatorCode = if (ctx.nullCheck) {
+ val operatorCode = if (commonType.isNullable) {
Review comment:
This is not well tested. `nullTerm` would not be declared and fail the
compilation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
