Myasuka commented on a change in pull request #19106:
URL: https://github.com/apache/flink/pull/19106#discussion_r827971967
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtilsTest.java
##########
@@ -95,39 +96,49 @@ public void testChooseTheBestStateHandleForInitial() {
when(keyedStateHandle3.getKeyGroupRange()).thenReturn(new
KeyGroupRange(8, 12));
keyedStateHandles.add(keyedStateHandle3);
- // this should choose no one handle.
- Assert.assertNull(
+ Assert.assertEquals(
+ keyedStateHandle2,
Review comment:
Why this test is different from previous one?
In my opion, we just make the option configurable, and it should not affect
the testing result since we did not change the default overlap fraction
threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
