[ 
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427851#comment-15427851
 ] 

ASF GitHub Bot commented on FLINK-4389:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2363#discussion_r75448294
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java
 ---
    @@ -33,19 +36,42 @@
      * group could for example include the task attempt number (more fine 
grained identification), or
      * exclude it (for continuity of the namespace across failure and 
recovery).
      */
    -public abstract class ComponentMetricGroup extends AbstractMetricGroup {
    +public abstract class ComponentMetricGroup<P extends AbstractMetricGroup> 
extends AbstractMetricGroup<P> {
    --- End diff --
    
    The `JobMetricGroup` is annotated as `internal`. I was just wondering 
whether we should do the same for this metric group and the others (to which it 
applies) as well. 


> Expose metrics to Webfrontend
> -----------------------------
>
>                 Key: FLINK-4389
>                 URL: https://issues.apache.org/jira/browse/FLINK-4389
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Metrics, Webfrontend
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-7%3A+Expose+metrics+to+WebInterface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to