link3280 commented on a change in pull request #19070:
URL: https://github.com/apache/flink/pull/19070#discussion_r827573064
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java
##########
@@ -261,8 +261,20 @@ public void addJar(String jarPath) {
return;
}
+ // merge the jar in config with the jar maintained in session
+ Set<URL> jarsInConfig;
+ try {
+ jarsInConfig =
+ new HashSet<>(
+ ConfigUtils.decodeListFromConfig(
+ sessionConfiguration,
PipelineOptions.JARS, URL::new));
+ } catch (MalformedURLException e) {
+ throw new SqlExecutionException(
+ "Failed to parse the option `pipeline.jars` in
configuration.", e);
+ }
Review comment:
@fsk119 Thanks a lot for your pointers! It clears lots of my doubts.
Updating the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
