rkhachatryan commented on a change in pull request #19051:
URL: https://github.com/apache/flink/pull/19051#discussion_r826733692



##########
File path: 
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractStateChangeLogger.java
##########
@@ -145,9 +145,17 @@ protected void log(
             @Nullable ThrowingConsumer<DataOutputViewStreamWrapper, 
IOException> dataWriter,
             Ns ns)
             throws IOException {
+        log(op, dataWriter, ns, keyContext.getCurrentKeyGroupIndex());
+    }
+
+    protected void log(
+            StateChangeOperation op,
+            @Nullable ThrowingConsumer<DataOutputViewStreamWrapper, 
IOException> dataWriter,
+            Ns ns,
+            int keyGroup)

Review comment:
       > the root cause of this problem is that it did not record the correct 
key group on logging
   
   Yes. I mean that such a contract should also be followed in all places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to