Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2363
Thanks for your contribution @zentol. I've gone over the code and made some
inline comments. My main concern/question is actually the representation of
metric's type and hierarchy information. I think that encoding it in a string
and then re-parsing it on the receiver side to reconstruct the information is
rather fragile and error-prone especially wrt maintainability. Maybe you can
give me some background why you decided to do it so.
Apart from that, I think the code contains many tests, which I really like
:-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
