LadyForest commented on a change in pull request #40: URL: https://github.com/apache/flink-table-store/pull/40#discussion_r823480245
########## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreReadImpl.java ########## @@ -44,6 +44,7 @@ private final Accumulator accumulator; private boolean keyProjected; + private boolean dropDelete = true; Review comment: why directly set `dropDelete` to `true`, when `FileStoreReadImpl.<init>`, it will be assigned to `false` anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org