zoucao commented on a change in pull request #18966:
URL: https://github.com/apache/flink/pull/18966#discussion_r821541527



##########
File path: docs/content.zh/docs/dev/table/data_stream_api.md
##########
@@ -596,13 +596,13 @@ pipeline or a statement set:
 
 ```java
 // execute with explicit sink
-tableEnv.from("InputTable").executeInsert("OutputTable")
+tableEnv.from("InputTable").insertInto("OutputTable").execute()

Review comment:
       Hi, @RocMarshal , could you help me confirm whether the ';' should be 
added for one line java code,
   for example :
   not added originally:
   
   > - Start from the earliest available message in the topic.
   >   ```java
   >   StartCursor.earliest()
   >   ```
   > - Start from the latest available message in the topic.
   >   ```java
   >   StartCursor.latest()
   >   ```
   > - Start from a specified message between the earliest and the latest.
   >   Pulsar connector would consume from the latest available message if the 
message id doesn't exist.
   > 
   >   The start message is included in consuming result.
   >   ```java
   >   StartCursor.fromMessageId(MessageId)
   >   ```
   added originally:
   
   > 
   > ```java
   > // discover new partitions per 10 seconds
   > PulsarSource.builder()
   >         
.setConfig(PulsarSourceOptions.PULSAR_PARTITION_DISCOVERY_INTERVAL_MS, 10000);
   > ```
   All were chosen from pulsar.md.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to